search

radicle-dev / radicle-upstream

Desktop client for Radicle.
Other
616 stars 51 forks source link

Flaky networking test on CI #2232

Closed geigerzaehler closed 2 years ago

geigerzaehler commented 3 years ago

The networking and patches tests sometimes fail on CI. The failure is due to data not replicated between the nodes.

geigerzaehler commented 3 years ago

In builds Github Actions we’re seeing the following warning

recv git error err=Rere(MissingSignedRefs(Urn { id: Oid(c7c303d71b4617696f8eca12b64780c267ad79a8), path: None }))

It’s repeated multiple times with the same URN.

geigerzaehler commented 3 years ago

Increasing the timeout for tests doesn’t help.

geigerzaehler commented 3 years ago

Here’s another failure which seems to be caused by a race condition around updating the signed refs (https://github.com/radicle-dev/radicle-link/issues/761)

geigerzaehler commented 3 years ago

Since https://github.com/radicle-dev/radicle-link/pull/777 we’re seeing the following error

recv git error err=Rere(Fetcher(Concurrent { urn: Urn { id: Oid(d8fd76b7f3eaecf62a11ead632bd580cca852b30), path: None }, remote_peer: hydkthp9j3ufuzt69nepfzu5x8wcmqmy9ckoi7hythguitfmoee5dh }))

https://buildkite.com/monadic/radicle-upstream/builds/10688#f13a8574-97d3-4309-8390-e2c7a4cb350e

rudolfs commented 3 years ago

This was fixed, right?

geigerzaehler commented 3 years ago

We’ve added some workarounds in #2391 but we should keep this issue open to remind us that we need to fix the underlying cause.

rudolfs commented 2 years ago

How about now?

geigerzaehler commented 2 years ago

I think we can close this. The tests are still flaky, but the migration to playwright should fix this.