radicle-dev / radicle-upstream

Desktop client for Radicle.
Other
616 stars 51 forks source link

Onboarding detection #2817

Closed geigerzaehler closed 2 years ago

geigerzaehler commented 2 years ago

At the moment, the mechanism that detects whether to show the onboarding screen is implemented by blocking the startup of the upstream-proxy services including the HTTP endpoint. This creates the following problems.

To address these problems, the GET /session endpoint of the API should provide information on whether the user is onboarded or not.

Fixing the implementation is a blocked by https://github.com/radicle-dev/radicle-cli/issues/77 as well as the fact that upstream-proxy creates an uninitialized profile on startup. If https://github.com/radicle-dev/radicle-cli/issues/77 is not addressed we can only work around this by having the upstream-proxy not create an uninitialized profile. Addressing the radicle-cli issue is preferred.

geigerzaehler commented 2 years ago

With https://github.com/radicle-dev/radicle-cli/issues/77 fixed it should be possible to remove the startup delay now. Could you take a look at this @efstajas?

efstajas commented 2 years ago

@geigerzaehler sure thing, I will take a look after patch statuses is done 👍

rudolfs commented 2 years ago

I've also sometimes run into a weird race condition, where the onboarding screen doesn't advance to the profile screen after an identity is created. Instead it hangs and an app refresh leads to the unlock screen. Don't have reliable repro steps yet.