Add another layer of tabs within Patches

radicle-dev / radicle-upstream

Desktop client for Radicle.

Other

616 stars 51 forks source link

Add another layer of tabs within Patches #2834

Closed rudolfs closed 2 years ago

rudolfs commented 2 years ago

This is in preparation to adding patch commenting. For now we can only show the "Commits" tab.

~~move the checkout, merge and close buttons to the top tab bar and make them available only in the patch context~~ -> https://github.com/radicle-dev/radicle-upstream/commit/91683cb1b3c3a130955e5f505a8398de8c7d7e8d
~~move the checkout project button to the files context~~ -> https://github.com/radicle-dev/radicle-upstream/commit/91683cb1b3c3a130955e5f505a8398de8c7d7e8d
~~add a link icon that copies the shareable id to the clipboard~~ -> https://github.com/radicle-dev/radicle-upstream/commit/91683cb1b3c3a130955e5f505a8398de8c7d7e8d
~~remove the main <- patchID component~~ -> https://github.com/radicle-dev/radicle-upstream/commit/91683cb1b3c3a130955e5f505a8398de8c7d7e8d

Proposed:

What we have now:

Kaihuang724 commented 2 years ago

@brandonhaslegs - Do you think it might be a good idea to add some color to the "Close Patch" and other actions in the top bar in the proposed design? It might be good for users to have positive/negative feedback at a quick glance.

efstajas commented 2 years ago

Currently there's two different "Commits" tabs, one project-level, one patch-level, and at least at first glance it's visually a bit unclear which one is for which.

I feel like we should move the project-level tabs to the grey bar at the top, together with all the other project-level information. That could make hierarchy a lot clearer.

brandonhaslegs commented 2 years ago

@Kaihuang724 I thought having two colored buttons up there felt really intense. This is what I tried though:

brandonhaslegs commented 2 years ago

@efstajas Yep, we've always wanted to try to figure this out. IMO this design would look a bit less confusing if it was built how it was intended, with the "collapsed header" seen here:

Kaihuang724 commented 2 years ago

@Kaihuang724 I thought having two colored buttons up there felt really intense. This is what I tried though:

Yeah that is kinda intense. Another option could be a simple modal that gets triggered when a user is closing a patch, like "Are you sure you want to close this? It's irreversible"

brandonhaslegs commented 2 years ago

Yes we should do the modal for sure!

geigerzaehler commented 2 years ago

Can we close this @rudolfs?