search

radicle-dev / radicle-upstream

Desktop client for Radicle.
Other
616 stars 51 forks source link

Warn user when the required version of Git cannot be found #2837

Closed geigerzaehler closed 2 years ago

geigerzaehler commented 2 years ago

Upstream requires at least version 2.35.1 of Git for pushes to seed nodes. (Git pushes to seed nodes are implemented as part of event logs in #2782.) If Upstream does not run this version changes to like closing a patch do not propagate to other peers until the user calls rad sync (or a similar command) in the project repository from their shell. Because of that we should make users aware that a certain version of Git is necessary and help them fix the issue.

One solution could be to show the onboarding screen if the required Git version is not found. The onboarding screen would mark everything but the Git step as completed.

Alternatively, we could show an error notification informing the user that the necessary Git version was not found.

geigerzaehler commented 2 years ago

I’d prefer the first solution.

efstajas commented 2 years ago

The onboarding screen already checks the git version today, but currently does not make it a blocking requirement (because we ran into exactly this issue where people actually did have a new git version installed, but we were only able to detect the outdated installation that comes with Mac OS depending on the user's env).

I wonder if we could somehow bundle git with upstream…? There's so many variables that could affect the user's env especially on Linux and I think it'd be quite hard to come up with a generally applicable set of instructions. It's also kind of hard to explain why you need to do it even if you're already running an up-to-date installation of git from homebrew or something in your shell.

rudolfs commented 2 years ago

Fixed via: https://github.com/radicle-dev/radicle-upstream/commit/c4b045a544f7b5998d13b7e3b7157ef4d6c077db.

Went with the least effort solution for now.