radicle-dev / radicle-upstream

Desktop client for Radicle.
Other
616 stars 51 forks source link

Posting a comment reloads the whole screen #2851

Closed rudolfs closed 2 years ago

rudolfs commented 2 years ago

Since we implemented the monorepo watcher, any change to the monorepo will trigger a screen reload, which is what happens when we post a comment.

Additionally, when the events for the monorepo changes stop working (due to https://github.com/radicle-dev/radicle-upstream/issues/2842), a comment doesn't show up after clicking the comment button.

And finally, if you're writing a comment while a network event arrives, it would reload the screen and you would lose the text you've written thus far.

Find a way to make the UX better, so that a whole page refresh isn't necessary when posting comments, but changes to the monorepo are still reflected in the project screen (i.e. new commits or patches arriving).

rudolfs commented 2 years ago

This was fixed with the recent source browsing refactoring.