radiegtya / meteoris2

a Realtime Javascript Boilerplate base on Meteor Js Framework
MIT License
246 stars 46 forks source link

Add Cucumber/Velocity testing #55

Closed martinhbramwell closed 9 years ago

martinhbramwell commented 9 years ago

Other little changes :

radiegtya commented 9 years ago

Look Promising, I'll just try to merge it. And if there are some problem, I'll tell You.

Thanks @martinhbramwell

martinhbramwell commented 9 years ago

Whew! I did not expect that. I would feel better if you would test things first.

radiegtya commented 9 years ago

Ofc I have already see your whole code(although without testing it), and I think it will not interrupt the main code. So it will be fine. I am pretty sure about my code scanning and skimming skill. LoL

martinhbramwell commented 9 years ago

Do you see this as a valid contribution?

Is it going where you want it to go? On Apr 18, 2015 7:43 AM, "Ega Wachid Radiegtya" notifications@github.com wrote:

Ofc I have already see your whole code(although without testing it), and I think it will not interrupt the main code. So it will be fine. I am pretty sure about my skill about code scanning and skimming. LoL

— Reply to this email directly or view it on GitHub https://github.com/radiegtya/meteoris/pull/55#issuecomment-94159215.

radiegtya commented 9 years ago

I haven't familiar with cucumber, but i need those feature. When I have time, I'll deeply understanding it first then re-check your work, or maybe come with new idea. Because right now I am still focusing on building CMS built with meteoris, and other apps.

martinhbramwell commented 9 years ago

Yes. I understand. Testing appears to be nothing more than a cause of delay. However, a product delivered without a serious self-test suite is not something that will attract a large group of collaborators , or of knowledgeable end users . Cucumber is important for developers who need to satisfy a single customer, by showing concrete proof that their requirements have been met

I haven't familiar with cucumber, but i need those feature. When I have time, I'll deeply understanding it first then re-check your work, or maybe come with new idea. Because right now I am still focusing on building CMS built with meteoris, and other apps.

— Reply to this email directly or view it on GitHub https://github.com/radiegtya/meteoris/pull/55#issuecomment-94174341.