search

radiegtya / meteoris2

a Realtime Javascript Boilerplate base on Meteor Js Framework
MIT License
246 stars 46 forks source link

Updated .sh file source paths & Added updateMongoUrl function #59

Closed innovateworld closed 9 years ago

innovateworld commented 9 years ago

Updated .sh file source paths

When I would run sh devRun.sh in terminal, I would get the following error

devRun.sh: line 3: source: utilsJson.sh: file not found

Changing source utilsJson.sh to source ./utilsJson.sh fixed the issue.

Added updateMongoUrl function

When I would runsh devrun.sh in terminal, I would get the following error

W20150502-02:49:30.516(-5)? (STDERR) throw(ex); W20150502-02:49:30.516(-5)? (STDERR) ^ W20150502-02:49:30.516(-5)? (STDERR) Error: failed to connect to [null:27017]

So I added a function that would only set MONGO_URL if DEVELOPMENT_MONGO_SERVER was not equal to null

radiegtya commented 9 years ago

@innovateworld : Thanks for the correction, I'll ask for martin suggestion about this.

@martinhbramwell : how do You think about this? :D

martinhbramwell commented 9 years ago

Yes, this is excellent help. There are a lot of ways a user might execute a bash script, and best practice techniques to catch edge cases. I certainly fell short in those two instances -- at least :-(

@innovateworld : Thank you so much for catching those. Your fixes are exactly right.

radiegtya commented 9 years ago

Ok then, I'll merge this now. Because honestly I don't understand much about this. Too much work right now, no time to study >.<