tags are not working - Githubissues

radify / radiian

Radiian creates Ansible provisioning files for immutable infrastructure on AWS

https://www.npmjs.com/package/radiian

BSD 3-Clause "New" or "Revised" License

19 stars 2 forks source link

tags are not working #61

Open gavD opened 8 years ago

gavD commented 8 years ago

I told Radiian my tag would be denzel-sample. AWS actually tags instances as denzel_sample (with an underscore).

this meant that provision.sh could not see my instances to destroy old nodes.

gavD commented 8 years ago

I haven't gotten to the bottom of this yet but I'm leaving the ticket here until I figure it out

gavD commented 8 years ago

ah, ok, so seems like AWS receives the tags fine, but ec2.py converts - to _. I'll keep an eye on it further.

Stillerman commented 8 years ago

ec2.py has a method tosafe that replaces "bad" characters with "". I think radiian should not allow anything with the "bad" characters in order to avoid confusion.

https://github.com/ansible/ansible/blob/d6b74f8f92632652de8092dfacfb6620b7e8c3bc/contrib/inventory/ec2.py#L1294

nateabele commented 8 years ago