search

radio-astro-tools / casa-formats-io

Code to handle I/O from/to data in CASA format
Other
10 stars 7 forks source link

Fix reading of IERS table #14

Closed astrofrog closed 3 years ago

astrofrog commented 3 years ago

This generalises the IncrementalStMan reader to handle multiple columns and buckets (still a WIP)

Fixes #13

codecov-commenter commented 3 years ago

Codecov Report

Merging #14 (a14851e) into main (5e247ad) will increase coverage by 0.04%. The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   95.69%   95.74%   +0.04%     
==========================================
  Files           4        4              
  Lines         930      940      +10     
==========================================
+ Hits          890      900      +10     
  Misses         40       40
Impacted Files Coverage Δ
casa_formats_io/casa_low_level_io.py 95.30% <96.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e247ad...a14851e. Read the comment docs.

astrofrog commented 3 years ago

@keflavich - can you test this locally to make sure it works for your version of the table? If it works it is ready to merge.

keflavich commented 3 years ago

lgtm!

In [1]: from casa_formats_io.casa_low_level_io import Table

In [2]: ct = Table.read('/Applications/CASA.app/Contents/Resources/casa-data/geodetic/IERSpredict', endian='<')

In [3]: ct.read_as_astropy_table()
Out[3]:
<Table length=181>
  MJD      x        Dx       y        Dy       dUT1      DdUT1             LOD                    DLOD            dPsi    DdPsi    dEps   DdEps
float64 float64  float64  float64  float64   float64    float64          float64                float64         float64  float64 float64 float64
------- -------- -------- -------- -------- ---------- --------- ----------------------- ---------------------- -------- ------- ------- -------
58735.0 0.213586  2.5e-05 0.338901  2.5e-05 -0.1547067   5.9e-06 -0.00042770000000000004  5.199999999999999e-06 -117.846   0.304 -11.234   0.089
58736.0 0.212926  2.2e-05 0.337602  1.6e-05  -0.154296   8.6e-06               -0.000374                4.2e-06 -117.797   0.029 -11.132     0.1
58737.0 0.211698  2.7e-05 0.336214  2.2e-05 -0.1539484   5.9e-06              -0.0003511  5.199999999999999e-06  -117.59   0.233 -11.037   0.106
58738.0 0.210383  2.7e-05 0.334449  2.5e-05 -0.1536001   5.9e-06              -0.0003092                3.9e-06 -117.378   0.233 -10.875   0.106
...