search

radio-astro-tools / casa-formats-io

Code to handle I/O from/to data in CASA format
Other
10 stars 7 forks source link

Fix support for tiled columns #22

Closed astrofrog closed 3 years ago

astrofrog commented 3 years ago

This is a work in progress that aims to fix support for the various kinds of tiled columns.

astrofrog commented 3 years ago

This now works locally, let's see what the CI says!

Note that read_as_astropy_table is now as_astropy_tables and returns a list of tables even if one table is present, but returns several for MS files with multiple DATA_DESC_IDs for example.

Once this works properly we can merge this and then start figuring out a good high-level API for users?

codecov-commenter commented 3 years ago

Codecov Report

Merging #22 (c10cc4c) into main (fd7c503) will increase coverage by 0.02%. The diff coverage is 97.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   96.13%   96.16%   +0.02%     
==========================================
  Files           4        4              
  Lines        1088     1146      +58     
==========================================
+ Hits         1046     1102      +56     
- Misses         42       44       +2
Impacted Files Coverage Δ
casa_formats_io/casa_low_level_io.py 95.94% <97.80%> (+0.04%) :arrow_up:
casa_formats_io/casa_dask.py 95.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd7c503...c10cc4c. Read the comment docs.

astrofrog commented 3 years ago

I'm going to go ahead and merge this as this fixes something that didn't work at all before anyway and we can fix things incrementally in follow-up PRs.