search

radio-astro-tools / casa-formats-io

Code to handle I/O from/to data in CASA format
Other
10 stars 7 forks source link

Reorganization of low-level IO code #24

Closed astrofrog closed 3 years ago

astrofrog commented 3 years ago

This PR is to reorganize the code for the the low-level I/O code following all the additions to read arbitrary tables.

codecov-commenter commented 3 years ago

Codecov Report

Merging #24 (90af248) into main (fd7c503) will decrease coverage by 51.00%. The diff coverage is 83.38%.

:exclamation: Current head 90af248 differs from pull request most recent head 6d0f042. Consider uploading reports for the commit 6d0f042 to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##             main      #24       +/-   ##
===========================================
- Coverage   96.13%   45.13%   -51.01%     
===========================================
  Files           4       15       +11     
  Lines        1088     2003      +915     
===========================================
- Hits         1046      904      -142     
- Misses         42     1099     +1057
Impacted Files Coverage Δ
casa_formats_io/casa_low_level_io.py 0.00% <0.00%> (-95.91%) :arrow_down:
casa_formats_io/casa_low_level_io/utils.py 0.00% <0.00%> (ø)
...asa_formats_io/casa_low_level_io/casa_functions.py 32.60% <32.60%> (ø)
casa_formats_io/casa_low_level_io/table.py 94.00% <94.00%> (ø)
...ormats_io/casa_low_level_io/data_managers/tiled.py 94.28% <94.28%> (ø)
casa_formats_io/casa_low_level_io/core.py 94.59% <94.59%> (ø)
casa_formats_io/casa_low_level_io/record.py 96.77% <96.77%> (ø)
..._io/casa_low_level_io/data_managers/incremental.py 98.75% <98.75%> (ø)
...ats_io/casa_low_level_io/data_managers/standard.py 99.30% <99.30%> (ø)
casa_formats_io/casa_dask.py 45.90% <100.00%> (-49.19%) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd7c503...6d0f042. Read the comment docs.

astrofrog commented 3 years ago

The code is now split into more sensible units of code, so I think it would make sense at this point to merge it and I can then start to tackle individual submodules for e.g. dask-ification and so on.

astrofrog commented 3 years ago

To be clear this PR does not change any code logic, it is just splitting things up.