radio-astro-tools / casa-formats-io

Code to handle I/O from/to data in CASA format
Other
10 stars 7 forks source link

Allow for missing Data Manager 0 #30

Closed keflavich closed 3 years ago

keflavich commented 3 years ago

Fix for Issue #29.

Open to suggestions on better ways to interact with iterators here.

codecov-commenter commented 3 years ago

Codecov Report

Merging #30 (89d4a73) into main (987cca5) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   55.39%   55.43%   +0.04%     
==========================================
  Files          16       16              
  Lines        2094     2096       +2     
==========================================
+ Hits         1160     1162       +2     
  Misses        934      934              
Impacted Files Coverage Δ
...asa_formats_io/casa_low_level_io/casa_functions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 987cca5...89d4a73. Read the comment docs.

astrofrog commented 3 years ago

I'm not sure how the casa functions behave when there are more than one data manager but this seems sensible in principle.

keflavich commented 3 years ago

OK, if you think it's reasonable, let's merge it?