Closed astrofrog closed 3 years ago
The test failure is due to https://github.com/dask/dask/issues/8387, waiting for input on that issue before proceeding.
Merging #32 (bef2c3d) into main (04b7412) will increase coverage by
0.24%
. The diff coverage is93.05%
.
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 55.39% 55.64% +0.24%
==========================================
Files 16 17 +1
Lines 2094 2117 +23
==========================================
+ Hits 1160 1178 +18
- Misses 934 939 +5
Impacted Files | Coverage Δ | |
---|---|---|
casa_formats_io/casa_low_level_io/table.py | 94.02% <83.33%> (-1.86%) |
:arrow_down: |
casa_formats_io/__init__.py | 100.00% <100.00%> (ø) |
|
casa_formats_io/casa_dask.py | 95.12% <100.00%> (ø) |
|
casa_formats_io/casa_low_level_io/__init__.py | 100.00% <100.00%> (ø) |
|
...asa_formats_io/casa_low_level_io/casa_functions.py | 100.00% <100.00%> (ø) |
|
...ormats_io/casa_low_level_io/data_managers/tiled.py | 94.87% <100.00%> (+0.20%) |
:arrow_up: |
casa_formats_io/table_reader.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 04b7412...bef2c3d. Read the comment docs.
I think this is ready for review/merging (review-wise, the main bit that is important is probably the docs)
I'll go ahead and merge since approved!
This also cleans up the API to use the standard astropy Table reader mechanism. With this, one can do e.g.:
I used the following script to check a 10Gb MS file and verified that all the data match between casatools and casa-formats-io:
There is a test failure I need to track down before we can merge, but this works fine with real-world data it seems!