search

radio-astro-tools / casa-formats-io

Code to handle I/O from/to data in CASA format
Other
10 stars 7 forks source link

Update the wheel builds for newer python versions and drop support for py 36 and 37 #44

Closed e-koch closed 2 years ago

e-koch commented 2 years ago

This should fix #43 for pip installs.

e-koch commented 2 years ago

One of the py37 versions is now failing to build...

codecov-commenter commented 2 years ago

Codecov Report

Merging #44 (ff20ee6) into main (6fc0e98) will decrease coverage by 10.38%. The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #44       +/-   ##
===========================================
- Coverage   56.42%   46.04%   -10.39%     
===========================================
  Files          18       18               
  Lines        2235     2235               
===========================================
- Hits         1261     1029      -232     
- Misses        974     1206      +232
Impacted Files Coverage Δ
casa_formats_io/casa_wcs.py 22.72% <0.00%> (-75.76%) :arrow_down:
casa_formats_io/casa_dask.py 22.30% <0.00%> (-73.08%) :arrow_down:
...asa_formats_io/casa_low_level_io/casa_functions.py 33.33% <0.00%> (-66.67%) :arrow_down:
casa_formats_io/casa_low_level_io/table.py 91.95% <0.00%> (-1.40%) :arrow_down:
casa_formats_io/casa_low_level_io/core.py 94.73% <0.00%> (-0.66%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fc0e98...ff20ee6. Read the comment docs.

e-koch commented 2 years ago

@keflavich @astrofrog Two things here:

  1. The failures are a version issue with markupsafe when building astropy v4.3.1 (https://github.com/astropy/astropy/pull/12877). But it's not using the wheels for numpy or astropy for whatever reason (https://github.com/radio-astro-tools/casa-formats-io/runs/6325393121?check_suite_focus=true#step:5:2426).
  2. It's taking ~1 hr to build/test the wheels for 5 python versions (3.6 - 3.10). Given CASA >6.4 is using at least python 3.8, can we start dropping support for 3.6 and 3.7?
keflavich commented 2 years ago

yes, :+1: to dropping older py's

astrofrog commented 2 years ago

Agree also with dropping older Pythons

e-koch commented 2 years ago

The wheels build is still very slow (~90 min) but passes. A quick check on the version updates would be appreciated!

keflavich commented 2 years ago

I can't see any problems. I'm amused that '3.10' requires quotes.