search

radio-astro-tools / casa-formats-io

Code to handle I/O from/to data in CASA format
Other
10 stars 7 forks source link

Switch to using the limited Python API #50

Closed astrofrog closed 2 years ago

astrofrog commented 2 years ago

This should allow only one wheel to be built per platform and be forward-compatible with all future Python 3 versions (which means we don't need to release a new version of casa-formats-io just because there is a new Python version). I'll need to check the wheel build logs to make sure things are working properly.

codecov-commenter commented 2 years ago

Codecov Report

Base: 46.04% // Head: 46.04% // No change to project coverage :thumbsup:

Coverage data is based on head (8ec56dc) compared to base (40ae85a). Patch has no changes to coverable lines.

:exclamation: Current head 8ec56dc differs from pull request most recent head bf460ee. Consider uploading reports for the commit bf460ee to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #50 +/- ## ======================================= Coverage 46.04% 46.04% ======================================= Files 18 18 Lines 2235 2235 ======================================= Hits 1029 1029 Misses 1206 1206 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

astrofrog commented 2 years ago

This seems to work well, will try and finalise thing shortly and mark as ready for review!

astrofrog commented 2 years ago

I think this is ready for review/merging. Just for info, if you look at the cibuildwheel logs, what is happening now is that it builds wheels for Python 3.8 and then tests for 3.8, 3.9, 3.10, and 3.11 using the same wheel. So once e.g. 3.12 comes out, we shouldn't have to build new wheels (except if the Python code in casa-formats-io doesn't work correctly with 3.12).