search

radio-astro-tools / pvextractor

Position-Velocity diagram extract (but it can slice out other things too)
BSD 3-Clause "New" or "Revised" License
16 stars 13 forks source link

tox failure #104

Closed keflavich closed 2 years ago

keflavich commented 2 years ago

We have a tox failure, even though the PR that enabled actions was all green: https://github.com/radio-astro-tools/pvextractor/pull/103

I can't reproduce this failure locally: https://github.com/radio-astro-tools/pvextractor/runs/4313817267?check_suite_focus=true

tox -v -e py39-test-novis-cov just works.

It looks like something is going wrong with qt? But this is a -novis branch? I guess novis doesn't do anything?

keflavich commented 2 years ago

so #105 failed - we don't have coverage and I don't know why. I'd rather have functional tests in place than coverage, so we'll work with this for now. I'd like to understand why it's failing though.

keflavich commented 2 years ago

I'll call this solved for the moment b/c we're no longer getting failures, but maybe we should open a new issue about not having coverage tests...