allow DaskSpectralCube, etc. to work

radio-astro-tools / pvextractor

Position-Velocity diagram extract (but it can slice out other things too)

BSD 3-Clause "New" or "Revised" License

16 stars 13 forks source link

allow DaskSpectralCube, etc. to work #99

Closed keflavich closed 2 years ago

keflavich commented 3 years ago

"isinstance" started failing w/DaskSpectralCube classes, so we check for duck-like attributes or subclass.

I picked a random attribute because I wasn't sure which one(s) we use; please suggest fixes if you figure out a better match!

coveralls commented 3 years ago

Coverage decreased (-81.5%) to 0.0% when pulling 45051ddbe61e7e255d11dfb99e0ef88562b76740 on keflavich:allow-other-cubetypes into a61673b38d59f395f53d0069ab6a7b7e2d3b99fd on radio-astro-tools:master.

keflavich commented 2 years ago

I'm merging this as it looks safe and tests are passing.