search

radio-astro-tools / radio-beam

A simple toolkit for reading and manipulating beams from astrophysical radio spectral data cubes.
https://radio-beam.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

Trap obscure flavor of CASA header #29

Closed low-sky closed 8 years ago

low-sky commented 8 years ago

Sometimes (old?) CASA seems to write out headers with AIPS-like HISTORY beam information (but with different line structures). These are hanging out in the image archives.

I've included a sample file in the data directory on test called m83.moment0.fits

e-koch commented 8 years ago

That header has no history of running exportfits, so maybe the archive is doing something else? The reduction was done in 4.2.1, so exportfits should be writing out the beam correctly in to a FITS header.

Also, we should probably keep names like from_casa_header reserved for instantiating from CASA images.

low-sky commented 8 years ago

Perhaps from_casa_fits_history or from_history and merge the AIPS style and CASA style?

low-sky commented 8 years ago

@keflavich -- Ready for review? Also is there any chance @e-koch could get write access?

e-koch commented 8 years ago

@low-sky - Can you also make a version of m83.moment0.fits with just the header? I don't think we'll need the data for testing in radio_beam (when we actually turn on CI).

keflavich commented 8 years ago

:+1: Would be great to turn on CI too. I'll merge this now, but if @e-koch wants to turn on CI... he now has write permission.

e-koch commented 8 years ago

Thanks! Will do soonish.