e-koch commented 3 years ago

We should make wheels in the release. I grabbed @astrofrog's publish workflow from https://github.com/radio-astro-tools/casa-formats-io

keflavich commented 3 years ago

lgtm, should we get @astrofrog's review before merging or go ahead?

astrofrog commented 3 years ago

Are there C extensions in radio-beam? If not we could build universal wheels, I can show how if needed.

e-koch commented 3 years ago

@astrofrog There's no C extension (yet). Guidance on building universal wheels would be much appreciated!

codecov-io commented 3 years ago

Codecov Report

Merging #93 (882d3a6) into master (b50714d) will decrease coverage by 0.41%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   85.35%   84.93%   -0.42%     
==========================================
  Files          12       12              
  Lines        1304     1268      -36     
==========================================
- Hits         1113     1077      -36     
  Misses        191      191

Impacted Files	Coverage Δ
radio_beam/multiple_beams.py	`72.31% <0.00%> (-0.91%)`	:arrow_down:
radio_beam/beam.py	`81.96% <0.00%> (-0.65%)`	:arrow_down:
radio_beam/tests/test_beam.py	`96.17% <0.00%> (-0.09%)`	:arrow_down:
radio_beam/tests/test_beams.py	`99.19% <0.00%> (-0.05%)`	:arrow_down:
radio_beam/tests/test_kernels.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b50714d...882d3a6. Read the comment docs.

e-koch commented 3 years ago

@astrofrog, @keflavich -- I think this is good to merge now. Pypi upload is set up for the repo, too.

radio-astro-tools / radio-beam

Add a publish workflow to github actions #93

Codecov Report