search

radio-astro-tools / radio-beam

A simple toolkit for reading and manipulating beams from astrophysical radio spectral data cubes.
https://radio-beam.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

Allow for units in headers that aren't just arcseconds #98

Closed keflavich closed 3 years ago

keflavich commented 3 years ago

See https://github.com/radio-astro-tools/spectral-cube/pull/737 and https://github.com/radio-astro-tools/spectral-cube/pull/738, which deal with this for fits file IO in spectral-cube. We should be using the radio-beam tools for this IO anyway...

codecov-commenter commented 3 years ago

Codecov Report

Merging #98 (beaf6f1) into master (0401345) will increase coverage by 0.08%. The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   85.83%   85.91%   +0.08%     
==========================================
  Files          12       12              
  Lines        1313     1335      +22     
==========================================
+ Hits         1127     1147      +20     
- Misses        186      188       +2
Impacted Files Coverage Δ
radio_beam/multiple_beams.py 73.71% <84.61%> (+0.48%) :arrow_up:
radio_beam/beam.py 84.70% <100.00%> (ø)
radio_beam/tests/test_beams.py 99.26% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0401345...beaf6f1. Read the comment docs.

e-koch commented 3 years ago

@keflavich -- Can you look at the test I added before merging this?