search

radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
97 stars 65 forks source link

Support AIPS-style unit specification #738

Closed keflavich closed 3 years ago

keflavich commented 3 years ago

The beam units are specified in the header of the BinTableHDU; we should be reading those when they're legit. Of course, in the first case we've seen them vary, AIPS uses non-standard unit names.

keflavich commented 3 years ago

Solves #737

keflavich commented 3 years ago

I don't understand the test failures right now; I think all the generated data should have the correct keyword arguments, but they're not showing up?

keflavich commented 3 years ago

@e-koch @astrofrog either of you know why there are failures during teardown? There are a ton of ERROR at teardown of messages, but they don't mean anything to me. I can't see any code changes that could have caused this, since the tests I edited are copy/pasted from others that do not cause a similar failure.

e-koch commented 3 years ago

Tests were failing on fixtures I added in #733. I've rebased to check this is the only place it's failing on.

codecov-commenter commented 3 years ago

Codecov Report

Merging #738 (d7dd383) into master (c3a9ece) will increase coverage by 0.16%. The diff coverage is 98.14%.

:exclamation: Current head d7dd383 differs from pull request most recent head b28cf0c. Consider uploading reports for the commit b28cf0c to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
+ Coverage   78.05%   78.22%   +0.16%     
==========================================
  Files          24       24              
  Lines        5727     5776      +49     
==========================================
+ Hits         4470     4518      +48     
- Misses       1257     1258       +1
Impacted Files Coverage Δ
spectral_cube/io/fits.py 85.43% <95.00%> (+1.10%) :arrow_up:
spectral_cube/conftest.py 92.48% <100.00%> (+0.65%) :arrow_up:
spectral_cube/spectral_cube.py 77.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3a9ece...b28cf0c. Read the comment docs.