search

radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
97 stars 65 forks source link

Add python3.9 to tests #744

Closed keflavich closed 3 years ago

keflavich commented 3 years ago

I'm also trying to fix the failure where py3.7 won't install astropy on windows, but I don't know how tox works yet.

codecov-commenter commented 3 years ago

Codecov Report

Merging #744 (f32739e) into master (cb01c81) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #744   +/-   ##
=======================================
  Coverage   78.21%   78.21%           
=======================================
  Files          24       24           
  Lines        5775     5775           
=======================================
  Hits         4517     4517           
  Misses       1258     1258

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb01c81...f32739e. Read the comment docs.

keflavich commented 3 years ago

The test failure in windows is different; it's https://github.com/radio-astro-tools/spectral-cube/pull/744/checks?check_run_id=3652552073#step:5:207.

It looks like it could be a cleanup failure? https://github.com/pytest-dev/pytest/issues/7724

keflavich commented 3 years ago

../../spectral_cube/tests/test_visualization.py .E.E.E.E.E.E.E.EFatal Python error: Aborted

the visualization test caused an abort trap...