radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes

http://spectral-cube.rtfd.org

BSD 3-Clause "New" or "Revised" License

98 stars 65 forks source link

Remove if statement that stops tox from running tests #759

Closed e-koch closed 3 years ago

e-koch commented 3 years ago

Found an accidental line from https://github.com/radio-astro-tools/spectral-cube/commit/31b2df04d8ceb4c8a9efd20c641ca77c2b542362 stopping tests from running without coverage enabled.

codecov-commenter commented 3 years ago

Codecov Report

Merging #759 (63fdec6) into master (26f3f1a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #759   +/-   ##
=======================================
  Coverage   77.54%   77.54%           
=======================================
  Files          24       24           
  Lines        5771     5771           
=======================================
  Hits         4475     4475           
  Misses       1296     1296

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26f3f1a...63fdec6. Read the comment docs.

e-koch commented 3 years ago

Ugh. the windows test fails again. https://github.com/radio-astro-tools/spectral-cube/runs/4084607756?check_suite_focus=true#step:5:150

e-koch commented 3 years ago

It looks like the distributed test is failing on windows (I think this is a new one, then): https://github.com/radio-astro-tools/spectral-cube/blob/master/spectral_cube/tests/test_dask.py#L211

@astrofrog any idea on this one? Or whether we could skip this test just for windows?

astrofrog commented 3 years ago

I'll try and look on Thursday but you could always merge this for now