search

radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
97 stars 65 forks source link

Attribute stokes_type #765

Closed preshanth closed 2 years ago

preshanth commented 2 years ago

Duplicate of #764

preshanth commented 2 years ago

@Kitchi and @keflavich If you both think this is okay. I will push and then setup another PR for the actual conversion between the different stokes parameter.

codecov-commenter commented 2 years ago

Codecov Report

Base: 78.21% // Head: 77.88% // Decreases project coverage by -0.32% :warning:

Coverage data is based on head (4a1e474) compared to base (de76f8a). Patch coverage: 38.77% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #765 +/- ## ========================================== - Coverage 78.21% 77.88% -0.33% ========================================== Files 24 24 Lines 5934 5982 +48 ========================================== + Hits 4641 4659 +18 - Misses 1293 1323 +30 ``` | [Impacted Files](https://codecov.io/gh/radio-astro-tools/spectral-cube/pull/765?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools) | Coverage Δ | | |---|---|---| | [spectral\_cube/stokes\_spectral\_cube.py](https://codecov.io/gh/radio-astro-tools/spectral-cube/pull/765/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools#diff-c3BlY3RyYWxfY3ViZS9zdG9rZXNfc3BlY3RyYWxfY3ViZS5weQ==) | `68.88% <38.77%> (-17.32%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

e-koch commented 2 years ago

@keflavich -- I think it's just the windows build? It's been failing for the last several weeks but should be unrelated to this PR. The non-dask tests in test_stokes_spectral_cube.py are passing.

preshanth commented 2 years ago

I am going to be pushing commits into my branch don't want the CI workflow spamming us all with emails about the status of the builds for now. I will work on a test and demonstration and then reopen this PR.

keflavich commented 2 years ago

I'd prefer that you push to a PR branch still. If you don't want CI running, add [ci skip] to the commit messages.

preshanth commented 2 years ago

Okay I have reopened the PR and will push some more code and request another review from you and krishna for merging this new code.

keflavich commented 2 years ago

@preshanth What's the status of this now?