search

radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
98 stars 65 forks source link

Issue 772: dask apply_along_axis missing kwargs #773

Closed keflavich closed 2 years ago

keflavich commented 2 years ago

This addresses #772 by passing kwargs and adds a test

codecov-commenter commented 2 years ago

Codecov Report

Merging #773 (9a0ab9c) into master (1f67a8f) will increase coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
+ Coverage   77.86%   77.95%   +0.08%     
==========================================
  Files          24       24              
  Lines        5811     5811              
==========================================
+ Hits         4525     4530       +5     
+ Misses       1286     1281       -5
Impacted Files Coverage Δ
spectral_cube/dask_spectral_cube.py 85.93% <100.00%> (+0.85%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f67a8f...9a0ab9c. Read the comment docs.

keflavich commented 2 years ago

This is good by me - whoever reviews, please merge if you think it's good

e-koch commented 2 years ago

@keflavich -- Added testing with and without the accepts_chunks parameter. accepts_chunks=False was missing from testing leading to this issue.

Otherwise, I also agree this is ready to merge.