search

radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
95 stars 62 forks source link

Deprecation fix: mktemp is deprecated #789

Open keflavich opened 2 years ago

keflavich commented 2 years ago

https://docs.python.org/3/library/tempfile.html#deprecated-functions-and-variables

codecov-commenter commented 2 years ago

Codecov Report

Merging #789 (5b3ad61) into master (7452dce) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #789   +/-   ##
=======================================
  Coverage   77.90%   77.90%           
=======================================
  Files          24       24           
  Lines        5826     5826           
=======================================
  Hits         4539     4539           
  Misses       1287     1287
Impacted Files Coverage Δ
spectral_cube/dask_spectral_cube.py 85.64% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7452dce...5b3ad61. Read the comment docs.

keflavich commented 2 years ago

Marked as 'draft' and may be a 'do-not-merge' b/c it appears the deprecated mktemp does something qualitatively different from mkstemp that will be hard to reproduce