search

radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
95 stars 62 forks source link

Allow general filter use instead of just median filters #812

Closed keflavich closed 1 year ago

keflavich commented 2 years ago

Is there a nicer way to inherit the docstrings?

codecov-commenter commented 2 years ago

Codecov Report

Merging #812 (634c2a3) into master (40401bd) will increase coverage by 0.09%. The diff coverage is 94.73%.

:exclamation: Current head 634c2a3 differs from pull request most recent head 75684ec. Consider uploading reports for the commit 75684ec to get more accurate results

@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
+ Coverage   77.90%   77.99%   +0.09%     
==========================================
  Files          24       24              
  Lines        5861     5876      +15     
==========================================
+ Hits         4566     4583      +17     
+ Misses       1295     1293       -2
Impacted Files Coverage Δ
spectral_cube/base_class.py 86.11% <ø> (ø)
spectral_cube/spectral_cube.py 76.64% <90.00%> (+0.05%) :arrow_up:
spectral_cube/dask_spectral_cube.py 85.14% <100.00%> (+0.12%) :arrow_up:
spectral_cube/cube_utils.py 82.59% <0.00%> (+1.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40401bd...75684ec. Read the comment docs.

keflavich commented 2 years ago

Ready for review

This PR basically just allows other filters to be used. I needed this for some reason I can't remember recently.... I think I wanted a percentile filter or something?