search

radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
95 stars 61 forks source link

Refactor of 813 #817

Closed keflavich closed 2 years ago

keflavich commented 2 years ago

This might be a cleaner way to do what #813 accomplished. Let's see. If it doesn't work, just close it.

codecov-commenter commented 2 years ago

Codecov Report

Merging #817 (412e1e5) into master (f12f10a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #817   +/-   ##
=======================================
  Coverage   77.94%   77.94%           
=======================================
  Files          24       24           
  Lines        5853     5853           
=======================================
  Hits         4562     4562           
  Misses       1291     1291

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f12f10a...412e1e5. Read the comment docs.

keflavich commented 2 years ago

ok this approach is just wrong apparently.