search

radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
95 stars 61 forks source link

CI: fixing version updates for actions and tox #855

Closed bsipocz closed 1 year ago

bsipocz commented 1 year ago

Also turning off daily cron, weekly should probably be more than sufficient

codecov-commenter commented 1 year ago

Codecov Report

Base: 77.36% // Head: 77.36% // No change to project coverage :thumbsup:

Coverage data is based on head (679698c) compared to base (13f4ea9). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #855 +/- ## ======================================= Coverage 77.36% 77.36% ======================================= Files 24 24 Lines 6026 6026 ======================================= Hits 4662 4662 Misses 1364 1364 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

bsipocz commented 1 year ago

@keflavich - this mostly fixes CI. The remaining issue seems to be real rather than CI/tox/etc related, so I leave it with you.

Also, this PR has added an upper limit for numpy version, I'll open another one with some of the fixes for 1.24 separately.

keflavich commented 1 year ago

Oops, I merged in the wrong order. I'll merge this one too. I'll fix the other open issue(s). Thanks @bsipocz, I would have been at this for days to figure out where the syntax changes arose!

bsipocz commented 1 year ago

This should not have been merged after the other PR.

(I suppose as a squash merge was done rather than a normal, the shared commit hashes wasn't detected and therefore the diff has been added erroneously to the master branch).

keflavich commented 1 year ago

Yes... I noticed that and mean to fix it, then got distracted. Thanks.