radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
98 stars 65 forks source link

MAINT: fix for np 1.24 #858

Closed bsipocz closed 1 year ago

bsipocz commented 1 year ago

This should fix #856

(Builds on top of #855, ideally that should go in first, along with the fixes with astropy dev)

codecov-commenter commented 1 year ago

Codecov Report

Base: 77.36% // Head: 77.36% // No change to project coverage :thumbsup:

Coverage data is based on head (25e5757) compared to base (13f4ea9). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #858 +/- ## ======================================= Coverage 77.36% 77.36% ======================================= Files 24 24 Lines 6026 6026 ======================================= Hits 4662 4662 Misses 1364 1364 ``` | [Impacted Files](https://codecov.io/gh/radio-astro-tools/spectral-cube/pull/858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools) | Coverage Δ | | |---|---|---| | [spectral\_cube/\_moments.py](https://codecov.io/gh/radio-astro-tools/spectral-cube/pull/858/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools#diff-c3BlY3RyYWxfY3ViZS9fbW9tZW50cy5weQ==) | `100.00% <100.00%> (ø)` | | | [spectral\_cube/dask\_spectral\_cube.py](https://codecov.io/gh/radio-astro-tools/spectral-cube/pull/858/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools#diff-c3BlY3RyYWxfY3ViZS9kYXNrX3NwZWN0cmFsX2N1YmUucHk=) | `85.14% <100.00%> (ø)` | | | [spectral\_cube/spectral\_cube.py](https://codecov.io/gh/radio-astro-tools/spectral-cube/pull/858/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools#diff-c3BlY3RyYWxfY3ViZS9zcGVjdHJhbF9jdWJlLnB5) | `76.49% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

keflavich commented 1 year ago

Thanks @bsipocz ! I'm going to merge this as it fixes many open issues, and the remaining windows-only issue seems to be something sort of real that we need to fix in a different issue.