search

radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
96 stars 63 forks source link

Find the real CASA beamtable #879

Closed AlecThomson closed 1 year ago

AlecThomson commented 1 year ago

A simple fix for #878

AlecThomson commented 1 year ago

Hi @keflavich, any movement on this PR? I have some downstream packages that would really appreciate this fix being in place

e-koch commented 1 year ago

@AlecThomson -- that's my bad for being slow here. I'll go through before the end of this week and get back to you.

In the meantime, restarting the tests on the last run. there were a few failures initially that may be due to this PR; let's see if those persisted after the last commit.

e-koch commented 1 year ago

@AlecThomson I think I've fixed the tests. I'll merge this if none of the test failures are related to this PR.

Our tests with beam tables also weren't using the extension name.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3d9ab27) 79.88% compared to head (5da466e) 79.88%.

:exclamation: Current head 5da466e differs from pull request most recent head aecd8bc. Consider uploading reports for the commit aecd8bc to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #879 +/- ## ======================================= Coverage 79.88% 79.88% ======================================= Files 24 24 Lines 6035 6035 ======================================= Hits 4821 4821 Misses 1214 1214 ``` | [Files Changed](https://app.codecov.io/gh/radio-astro-tools/spectral-cube/pull/879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools) | Coverage Δ | | |---|---|---| | [spectral\_cube/conftest.py](https://app.codecov.io/gh/radio-astro-tools/spectral-cube/pull/879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools#diff-c3BlY3RyYWxfY3ViZS9jb25mdGVzdC5weQ==) | `93.49% <100.00%> (ø)` | | | [spectral\_cube/io/fits.py](https://app.codecov.io/gh/radio-astro-tools/spectral-cube/pull/879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools#diff-c3BlY3RyYWxfY3ViZS9pby9maXRzLnB5) | `86.62% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

e-koch commented 1 year ago

thanks @AlecThomson !

AlecThomson commented 1 year ago

Thanks all!