search

radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
96 stars 63 forks source link

fix parameter syntax error introduced in PR 883 #885

Closed tvwenger closed 1 year ago

tvwenger commented 1 year ago

See https://github.com/radio-astro-tools/spectral-cube/issues/884

keflavich commented 1 year ago

Could you add a test for this? It's not covered in our current tests. I can have a look but probably not immediately

keflavich commented 1 year ago

Actually our tests do cover this and I merged a red PR. Bad.

tvwenger commented 1 year ago

Actually our tests do cover this and I merged a red PR. Bad.

No worries, it happens to the all of us!

tvwenger commented 1 year ago

I notice that a lot of these tests are failing with errors:

TypeError: _new_view() got an unexpected keyword argument 'propagate_info'

Are these expected?

keflavich commented 1 year ago

No, they're a consequence of https://github.com/astropy/astropy/pull/14518. I have a bugfix in progress.

keflavich commented 1 year ago

merged in #886