radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
95 stars 61 forks source link

Fix failing newview #886

Closed keflavich closed 1 year ago

keflavich commented 1 year ago

There was some refactor of Quantity upstream that we didn't properly accommodate.

This PR incorporates #885 too.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4793c27) 79.88% compared to head (f190e3d) 79.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #886 +/- ## ======================================= Coverage 79.88% 79.88% ======================================= Files 24 24 Lines 6035 6035 ======================================= Hits 4821 4821 Misses 1214 1214 ``` | [Impacted Files](https://app.codecov.io/gh/radio-astro-tools/spectral-cube/pull/886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools) | Coverage Δ | | |---|---|---| | [spectral\_cube/lower\_dimensional\_structures.py](https://app.codecov.io/gh/radio-astro-tools/spectral-cube/pull/886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools#diff-c3BlY3RyYWxfY3ViZS9sb3dlcl9kaW1lbnNpb25hbF9zdHJ1Y3R1cmVzLnB5) | `84.70% <100.00%> (ø)` | | | [spectral\_cube/masks.py](https://app.codecov.io/gh/radio-astro-tools/spectral-cube/pull/886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radio-astro-tools#diff-c3BlY3RyYWxfY3ViZS9tYXNrcy5weQ==) | `80.25% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

keflavich commented 1 year ago

I removed #885 and force-pushed to see if that causes tests to fail (with that included, tests passed!)

keflavich commented 1 year ago

We still don't have a test that checks for the deprecation in #883, but that's probably b/c we're not checking for deprecations in tests.

keflavich commented 1 year ago

The CASA test has been hung waiting for a runner for 5 hours now; everything else is green. I'm merging.