radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
96 stars 63 forks source link

MNT: Clean up _astropy_init.py #891

Closed pllim closed 11 months ago

pllim commented 11 months ago

Because config stuff is unnecessary and removed in astropy v6.0, see:

And I don't think you even use it anyway?

This is failing our devdeps job in Jdaviz CI (e.g., https://github.com/spacetelescope/jdaviz/pull/2409) because even though Jdaviz does not use this package, glue-astronomy refuses to make this package optional.

cc @astrofrog @keflavich

pllim commented 11 months ago

Failure is unrelated. Looks like you need to clean up your CI infrastructure, which is out of scope here.

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Files Coverage Δ
spectral_cube/_astropy_init.py 77.77% <100.00%> (+24.20%) :arrow_up:

... and 1 file with indirect coverage changes

:loudspeaker: Thoughts on this report? Let us know!.

keflavich commented 11 months ago

@astrofrog @e-koch I'm good to merge this, even with CI red, as long as we're confident we're not using it.

We do need to update CI elsewhere.

e-koch commented 11 months ago

Agreed on merging now and fixing the CI issue elsewhere.

pllim commented 11 months ago

PSA: You might wanna release before astropy v6.0 comes out at the end of the year. See https://github.com/astropy/astropy/wiki/Release-Calendar

pllim commented 11 months ago

Thanks for the merge!