search

radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
95 stars 61 forks source link

Moving stokes spectralcube to be compatible with astropy stokes WCS. #905

Open preshanth opened 2 months ago

preshanth commented 2 months ago

The goal here is move the special types and checks we have in place and instead use the astropy based stokes values. The will work for the polarization cases that are defined in astropy stokes WCS. The remaining cases we can define using the custom declaration for stokes that is built into astropy.

I am working on this and want to have it ready so we can code review in person @keflavich

keflavich commented 2 months ago

could you get the PR submitted before I'm out there?

preshanth commented 2 months ago

That is the plan. Else before we cross paths in CV

From: Adam Ginsburg @.> Sent: Tuesday, April 23, 2024 6:01:23 AM To: radio-astro-tools/spectral-cube @.> Cc: Preshanth Jagannathan @.>; Author @.> Subject: Re: [radio-astro-tools/spectral-cube] Moving stokes spectralcube to be compatible with astropy stokes WCS. (Issue #905) {External}

could you get the PR submitted before I'm out there?

— Reply to this email directly, view it on GitHubhttps://github.com/radio-astro-tools/spectral-cube/issues/905#issuecomment-2072120662, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AARIMUMEXLGNCJ5KOEMXLS3Y6ZERHAVCNFSM6AAAAABGT56O36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZSGEZDANRWGI. You are receiving this because you authored the thread.Message ID: @.***>

[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/radio-astro-tools/spectral-cube/issues/905#issuecomment-2072120662", "url": "https://github.com/radio-astro-tools/spectral-cube/issues/905#issuecomment-2072120662", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]