search

radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
95 stars 61 forks source link

fix for 915: account for different use cases of median #916

Open keflavich opened 2 weeks ago

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (7bc6bac) to head (4d7182f). Report is 4 commits behind head on master.

:exclamation: Current head 4d7182f differs from pull request most recent head 8486580

Please upload reports for the commit 8486580 to get more accurate results.

Files Patch % Lines
spectral_cube/spectral_cube.py 45.45% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #916 +/- ## ========================================== - Coverage 79.94% 79.84% -0.10% ========================================== Files 24 24 Lines 6013 6024 +11 ========================================== + Hits 4807 4810 +3 - Misses 1206 1214 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

keflavich commented 1 week ago

There's a bug in warn_slow: it should inspect the function being called to see whether it accepts a how keyword. Presently, it's warning users to use the how keyword even if they're using DaskSpectralCubes

keflavich commented 1 week ago

the last two commits might've been a red herring; I don't think dask is raising the wrong error message.