Make pixscale values robust to non-square pixels

radio-astro-tools / uvcombine

Combine images made with different resolutions, including the "feathering" technique for interferometry data.

https://uvcombine.readthedocs.io

19 stars 15 forks source link

Make pixscale values robust to non-square pixels #35

Open e-koch opened 2 years ago

e-koch commented 2 years ago

See https://github.com/astropy/astropy/pull/13268.

We use pixscale = wcs.utils.proj_plane_pixel_scales(cube_hi.wcs.celestial)[0] throughout uvcombine and this poses the risk of not catching non-square pixels.

keflavich commented 2 years ago

it's such a minor thing here that I don't think we need to do anything about it right now, but I'm tired of using that really long and somewhat easy-to-break pattern