Add active links to r4-app-menu

radio4000 / components

web-components to build the r4 interfaces, uses the sdk

https://components.radio4000.com/

1 stars 0 forks source link

Closed oskarrough closed 1 year ago

oskarrough commented 1 year ago

Adds an 'active' attribute to the r4-app-menu.

[x] ensure the app menu re-renders on route change
[x] is active the right attribute to add? Maybe there is some aria-current instead

Potentially we want active-styles outside of r4-app-menu as well, but that can come laters as well.

Closes #114

netlify[bot] commented 1 year ago

Name	Link
Latest commit	50250819bb71d96ec9a80f6d4d1e9504fed95513
Latest deploy log	https://app.netlify.com/sites/radio4000-components/deploys/654221d0034c2f0008b99142
Deploy Preview	https://deploy-preview-149--radio4000-components.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

oskarrough commented 1 year ago

Switched to use aria-current="page" for active links. I conditionally render the attribute using Lit's nothing https://lit.dev/docs/api/templates/#nothing