feat/layout-player: update layout w/ buttons states [close, dock, minimize, fullscreen]

radio4000 / components

web-components to build the r4 interfaces, uses the sdk

https://components.radio4000.com/

1 stars 0 forks source link

Closed 4www closed 1 year ago

4www commented 1 year ago

add buttons for states [close, dock, minimize, fullscreen]
had to use shadow dom (for slots to render their children inside the component render() tree). So can use r4-layout-* html elements to encapsulate)
there is a close button (tbd)
[x] add back unicode chars for layout buttons?
[x] r4-layout[sticky="true"], shows player and main menu sticky top and bottom in small mode?
?

Closes #29

netlify[bot] commented 1 year ago

Name	Link
Latest commit	bcbeb90587414ab88e1c0d72a885000dc342006c
Latest deploy log	https://app.netlify.com/sites/radio4000-components/deploys/6456228405cbdd0008a29c36
Deploy Preview	https://deploy-preview-40--radio4000-components.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

oskarrough commented 1 year ago

Super good!

I didn't expect the close button to stop playback actually. Is there another word we can use?

On desktop layout we could still keep the buttons on top, like in smaller layout. I think it snugs well to the top of the player.

Icons/unicode would imo improve it, I think we can find good ones for each.

oskarrough commented 1 year ago

What about the order of the buttons? I'd put mini first, then dock and finally fullscreen.

4www commented 1 year ago

merging so we can start using what's there. very welcome to come up with follow up updates, renames, changes!