search

radiocosmology / caput

Cluster Astronomical Python Utilities
GNU General Public License v2.0
12 stars 21 forks source link

fix(mpiarray): crash testing for an Ellipsis when given an ndarray index #200

Closed jrs65 closed 2 years ago

jrs65 commented 2 years ago

Yeah, they are related but it's a bit subtle. The problem with the old code was that if you pass in a numpy array as an array index it does an element wise comparison to Ellipsis and then complains that you need to use .all() or .any() on the result. So this test now checks that case and thus throws an error with the previous implementation.

ljgray commented 2 years ago

Any reason this hasn't been merged? Ran into the Ellipsis crash issue so having to use this branch to get around it.