When installing caput with cython 3.x, the build fails because the c++ language directive in setup.py is ignored.
The distutils language directives in various .pyx files seem to have always been ignored if they were below a docstring, because this was treated differently from a comment.
These issues are partially fixed in #246, but we should extend that fix to all .pyx files in caput. The first issue is also avoided by either fixing our build environment to use cython < 3, or by installing with the--no-build-isolation flag and an environment already using cython < 3. This is why mkchimeenv script worked, but only when using the --fast flag which uses --no-build-isolation under the hood.
For now we should just merge #246, but I think we should take a better look a the build environment
ljgray
commented
1 year ago
There are two related issues here:
setup.pyis ignored.These issues are partially fixed in #246, but we should extend that fix to all .pyx files in caput. The first issue is also avoided by either fixing our build environment to use cython < 3, or by installing with the
--no-build-isolationflag and an environment already using cython < 3. This is whymkchimeenvscript worked, but only when using the--fastflag which uses--no-build-isolationunder the hood.For now we should just merge #246, but I think we should take a better look a the build environment