Intelligently set `z_error` field for mock catalogs

radiocosmology / draco

A pipeline for the analysis and simulation of drift scan radio data

MIT License

9 stars 7 forks source link

Intelligently set `z_error` field for mock catalogs #151

Open sjforeman opened 3 years ago

sjforeman commented 3 years ago

The SpectroscopicCatalog container has a z_error field that currently isn't modified by the Add{Gaussian,EBOSS}ZErrorsToCatalog tasks. It would make sense to store the standard deviation of the distribution the z errors are drawn from (added in quadrature to the existing z_error value if one exists).

ljgray commented 2 years ago

@sjforeman Is this issue resolved in #149? If so, we should close it

sjforeman commented 2 years ago

@ljgray Unfortunately no - in #149, we punted on deciding what exactly the z_error field should store (see https://github.com/radiocosmology/draco/pull/149#discussion_r679617194), so we didn't write any code to set it.