search

radiolarian / AO3Scraper

A Python scraper for getting fan fiction content and metadata from Archive of Our Own.
175 stars 56 forks source link

Scrape fics of a certain language #18

Closed jaevibing closed 3 years ago

jaevibing commented 3 years ago

I added a new argument that allows the user to scrape fics of only a certain language (e.g. only French fics). The argument is --lang and I updated the documentation for this new feature.

ssterman commented 3 years ago

Thanks for the new feature! It's a great idea. I've left some comments in the code that will simplify future maintenance; take a look and make the changes, then I can look into merging.

jaevibing commented 3 years ago

Thanks for the new feature! It's a great idea. I've left some comments in the code that will simplify future maintenance; take a look and make the changes, then I can look into merging.

I've made some changes to the code, I'll run a test to verify it works correctly.

jaevibing commented 3 years ago

Thanks for the new feature! It's a great idea. I've left some comments in the code that will simplify future maintenance; take a look and make the changes, then I can look into merging.

I've made some changes to the code, I'll run a test to verify it works correctly.

I ran a test and it worked as expected, should be all good to go.

ssterman commented 3 years ago

Looks great!