search

radiolarian / AO3Scraper

A Python scraper for getting fan fiction content and metadata from Archive of Our Own.
172 stars 55 forks source link

blank lines between entries on windows #23

Closed AJHoeh closed 2 years ago

AJHoeh commented 3 years ago

Hey there,

at least on windows using the ao3_work_ids.py script will result in a file with every other line beeing blank. Adding newline="" as argument to the open() call in line 193 fixes it for me. I will test whether this is relevant for linux aswell.

Edit: This seems to be windiws specific, but the fix I mentioned seems to not affect linux behaviour at all so I guess it could be worth implementing

Edit2: ao3_get_fanfics.py is also hit (lines: 269, 271, 280)

ssterman commented 3 years ago

Good catch. Want to make a pull request?