search

radiolib-org / RadioBoards

Crowd-sourced database of radio module pinouts
MIT License
3 stars 2 forks source link

Add support for Adafruit Feather RP2040 RFM #4

Closed timmbogner closed 3 months ago

timmbogner commented 3 months ago

Hope everything looks okay!

StevenCellist commented 3 months ago

@jgromes how do you envision discerning between 'contributed' and 'maintained'? Would maintained only include boards that are tested by RadioLib contributors? In my own opinion, if users can provide a debug log showing a handful of LoRaWAN uplinks & downlink, that would be OK as well to move a board to maintained, because if something is wrong with the radio, LW won't work. But it quite depends on the definition of 'maintained'.

timmbogner commented 3 months ago

@StevenCellist I was also wondering if there was a good method to verify the configuration. I'm not using LoRaWAN, so a different method of proof would work better for me. For this, I only verified that it initialized.

jgromes commented 3 months ago

@StevenCellist you are right that it's not a completely clear distinction between the two ... so far I have settled on two criteria for maintained boards:

  1. Verified by RadioLib org members
  2. Can be quickly tested when users report issues

The first point can be satisfied by a log showing working communication, be it LoRaWAN or P2P (I agree that LoRaWAN OTAA+uplink is a nice end-to-end test). The second one is trickier, because it requires some sort of access to the hardware. So if we move a board from contributed to maintained, and then there's a problem, we might not have a way to replicate the issue.

But again, the distinction is not very clear, we may revisit this separation (or drop it altogether) at a later point.

StevenCellist commented 3 months ago

@jgromes sure, looks fair to me. Thread hijack closed ;)

jgromes commented 3 months ago

All looks good now - merged, thank you!