radiology-research / ispy2_mri

GUI to enter info on incoming MRI's for ISPY2 into database
GNU General Public License v3.0
0 stars 0 forks source link

clear old values after save #6

Closed RossBoylan closed 11 months ago

RossBoylan commented 1 year ago

If one saves one entry and then loads another from a file, some of the old entries may persist. This will be any field that wasn't overwritten. As I recall, that includes fields with values in the text file that don't match the allowed inputs.

Arguably the current behavior is a bug.

RossBoylan commented 11 months ago

There are 3 points at which the data could be cleared:

  1. Immediately after hitting save and data committed to db.
  2. After user clicks OK on message that save was successful.
  3. Immediately before reading data in from a file.

@Teffany prefers 2. In favor of 2:

In favor of 3:

For safety, clear data at points 2 and 3.