search

radiomanV / TL866

Open source software for TL866
GNU General Public License v2.0
345 stars 80 forks source link

Compile error "invalid use of incomplete class QUrl" building TL866_Updater #15

Closed phenn closed 6 years ago

phenn commented 6 years ago

Hi, obviously the mainwindow.cpp got to many cleanups. I could not compile the TL866_Updater. Looks like an include of was gone away.

This qurl-missing-fix-patch.txt :

--- a/TL866_Updater/QT/mainwindow.cpp
+++ b/TL866_Updater/QT/mainwindow.cpp
@@ -20,6 +20,7 @@
 * USA.
 */

+#include <QUrl>
 #include <QWidget>
 #include <QFileDialog>
 #include <QMessageBox>

fix that problem for me.

Kind Regads, Peter

radiomanV commented 6 years ago

Hi Peter, Indeed too many cleanups but the QUrl was never included at all and never encountered that error so far. Please tell me where at which line in mainwindow.cpp is that ""invalid use of incomplete class QUrl"" error?

phenn commented 6 years ago

Hi radioman,

oh, that was not even one error. When I stash the fix, you can take a look at the build.log. So I guess the missing include was formerly already in one of the removed includes.

Sorry, the make output is not efficient. Qt-Creator does show it better: qt_creator

Regards, Peter

radiomanV commented 6 years ago

Hi again, I checked in my two development machines (Linux and windows) and compile is ok without that QUrl include. Normally you're right, it should be included because of isLocalFile and toLocalFile from the drag and drop events which i have implemented in my last commit (cleanup :)). I don't know why in my setup i don't have these errors that you have (maybe different qt versions). So here is, commited this fix Thank you.