search

radiomanV / TL866

Open source software for TL866
GNU General Public License v2.0
334 stars 79 forks source link

macOS support #23

Closed troed closed 4 years ago

troed commented 4 years ago

macOS support added. Existing libusb code used for reading and writing, IOKit is used instead of libudev since the latter doesn't exist on macOS.

radiomanV commented 4 years ago

Thanks for the MacOS support! However i have one question: why do you duplicate the usb_linux.h and usb_linux.c as usb_macos.h and usb_macos.c? the easiest solution is to use usb_linux.h/c as is in macos. If you intend to rewrite the usb class using the macos IOKIT then yes this make sense to have separate implementation per OS. Anyway i'll merge this pull request no problem.

In the other hand i'm glad that someone actually shake the dust of this project. It was more like a proof of concept project written in a hurry about six years ago with code taken from my other older projects. I should make myself some time to revisit and correct some code but i don't know when i'll have such time. If you have anything to add/change please make it so. I will gladly accept any contribution.

troed commented 4 years ago

Thanks! Yeah the files are separated since a rewrite to IOKit really should be done. I'm just not certain I will find the time to get around to it unfortunately so better the code got to possibly benefit others as it is.