search

radiorabe / centos-rpm-fdk-aac-dabplus-odr

CentOS 7 RPM Specfile for Opendigitalradio's fork of fdk-aac-dabplus
https://github.com/Opendigitalradio/fdk-aac
1 stars 1 forks source link

Problem: too much undocumented branches #7

Open hairmare opened 7 years ago

hairmare commented 7 years ago

I think https://github.com/radiorabe/centos-rpm-fdk-aac-dabplus-odr/commit/c24761c91d6c8c6a8e4ea11517c4b36051424cdc is a leaf in a branch that does not have any relevant changes left to merge. Here's a merge: https://github.com/radiorabe/centos-rpm-fdk-aac-dabplus-odr/compare/radiorabe:512cc4f...radiorabe:c24761c

Also, it looks like legacy-fdk-aac-dabplus is just there to point to https://github.com/radiorabe/centos-rpm-fdk-aac-dabplus-odr/commit/86a8e8c2fbc3445e278bea5f2c83100caddda6dc.

Have a look at the network graph to see them.

Proposed Solution:

edit: what's wrong with link formatting 🙁 wtf, /commit/ worky, /tree/ no-worky 😲

paraenggu commented 7 years ago

Theodr-project-reorg branch can be removed, it was a temporary development branch which was used while adapting the spec to upstream's project reorganisation and got finally merged into master.

legacy-fdk-aac-dabplus reflects the state of the package before upstream's project reorg. I don't see any harm in keeping this branch around. It was already helpful in the past to see how the package and the software was organized before.

hairmare commented 7 years ago

Removed odr-project-reorg.

I was expecting such an explanation of the legacy-fdk-aac-dabplus branch. I hear there's a tool called git that supports tags.

If you want to add more context you could annotate the tag, the version I provided 1.2.0-0.fdk.2.3.2.odr.toolame.0.2l.odr is based on the state of things in the specfile atm. I think it is correct and reflects the contents of the package at that state.

hairmare commented 7 years ago

1.2.0-1 would also be a proper way to tag it, at least that's what was accepted in the changelog.