search

radiorabe / centos-rpm-liquidsoap

RaBe Liquidsoap Distribution for CentOS 8 & Fedora (RaBe-LSD)
https://build.opensuse.org/project/show/home:radiorabe:liquidsoap
GNU General Public License v3.0
9 stars 3 forks source link

Bump to liquidsoap 1.3.3 #15

Closed hairmare closed 6 years ago

hairmare commented 6 years ago

Due to updates in CentOS the bump to 1.3.3 is now feasible. SSL support still needs to wait since ocaml-ssl was not bumped in CentOS.

Fixes #14

@paraenggu I tested this bump locally against all the Liquidsoap packages from RaBe LSD once they finally built again.

hairmare commented 6 years ago

Address rpmlint warnings

See a6672a4bc2f5b9410ac23a11f137cc94d54f6962, IMO the remaining warnings don't apply to this case.

Improve Man Page handling

Done

Improve systemd handling (Packaging:Systemd and Systemd scriptlets)

Done (these where not yet available at the original time of writing)

Use macros for directories and install commands (such as %make_install)

I was able to use %make_install but didn't find any others that make sense (ie. %configure is for autotools style configure scripts and this isn't really that)

Append the Dist tag to the release field

Done, AFAIK these currently get overridden by OBS anyway

Sort the BuildRequires directives in alphabetically ascending order

Done

Add a license and copyright header

Done

hairmare commented 6 years ago

For the record, these are the rpmlint warnings still there:

liquidsoap.spec:94: W: configure-without-libdir-spec
liquidsoap.spec: W: invalid-url Source0: https://github.com/savonet/liquidsoap/releases/download/1.3.3/liquidsoap-1.3.3.tar.bz2 HTTP Error 403: Forbidden

The first one is a false positive, the second one some seems to be a flake since spectool is able to fetch the file anyway.